Define typed application service boundaries #19

JayKobe6k · 2026-09-03T14:39:06Z

JayKobe6k commented

2026-09-03 14:39:06 +00:00

Summary

add typed requests, results, and errors for index creation, updates, search, and lineage
define frontend-facing use-case interfaces and application-owned adapter ports
document the application boundary and test typed dispatch/error propagation with in-memory fakes

Tests

nix develop --command cargo fmt --all -- --check
nix develop --command cargo lint
nix develop --command cargo test --all-targets --all-features
nix develop --command cargo doc --no-deps --all-features

Closes #2

## Summary - add typed requests, results, and errors for index creation, updates, search, and lineage - define frontend-facing use-case interfaces and application-owned adapter ports - document the application boundary and test typed dispatch/error propagation with in-memory fakes ## Tests - `nix develop --command cargo fmt --all -- --check` - `nix develop --command cargo lint` - `nix develop --command cargo test --all-targets --all-features` - `nix develop --command cargo doc --no-deps --all-features` Closes #2

JayKobe6k added 1 commit

2026-09-03 14:39:06 +00:00

Define typed application service boundaries

Validate / Formatting, linting, and tests (push) Successful in 1m50s

Details

Validate / Formatting, linting, and tests (pull_request) Successful in 1m59s

Details

dc2b14e815

JayKobe6k referenced this pull request

2026-09-03 15:49:33 +00:00

Build the CLI command and output contract #20

JayKobe6k reviewed

2026-09-03 23:15:22 +00:00

JayKobe6k left a comment

Found two actionable issues in the application service boundary.

src/application/mod.rs

					
				@ -0,0 +989,4 @@

				        &self,

				        request: CreateIndexRequest,

				    ) -> Result<IndexResult, ApplicationError> {

				        self.create.create_index(request)

[P1] This facade only delegates to an injected CreateIndexUseCase, but the application module provides no concrete service that orchestrates the source, compilation, parser, analysis, repository, and catalog ports; the tests substitute a fake for the entire use case instead of exercising application behavior through fake ports. As a result, none of the documented indexing, refresh, or query workflows is executable through the shared application layer. Please implement the application-owned services over the port traits and test those services with in-memory port fakes.

[P1] This facade only delegates to an injected `CreateIndexUseCase`, but the application module provides no concrete service that orchestrates the source, compilation, parser, analysis, repository, and catalog ports; the tests substitute a fake for the entire use case instead of exercising application behavior through fake ports. As a result, none of the documented indexing, refresh, or query workflows is executable through the shared application layer. Please implement the application-owned services over the port traits and test those services with in-memory port fakes.

src/application/mod.rs Outdated

					
				@ -0,0 +1231,4 @@

				    ///

				    /// Returns the adapter's typed error when the catalog cannot be updated

				    /// atomically.

				    fn register_index(&self, index: &ResolvedIndex) -> Result<(), Self::Error>;

[P1] The catalog port can read the active revision but cannot activate a newly built revision or perform the required compare-and-swap. Any concrete index or refresh service would have to bypass this boundary to publish atomically, which breaks the application-port architecture and permits lost updates. Please add a typed activation operation carrying the expected and replacement revisions, with an explicit conflict result.

JayKobe6k added 1 commit

2026-09-04 00:47:34 +00:00

Implement application service orchestration

Validate / Formatting, linting, and tests (pull_request) Successful in 1m57s

Details

Validate / Formatting, linting, and tests (push) Successful in 9m4s

Details

e190aef566

JayKobe6k commented

2026-09-04 00:48:08 +00:00

Review comment #922: Fixed in e190aef. The catalog boundary now plans immutable descriptors and activates them with a typed compare-and-swap request whose conflict is an explicit application outcome. Fake-port tests cover stale activation after persistence. Validation: full formatting, lint, all-target/all-feature tests, and rustdoc passed.

Review comment #922: Fixed in e190aef. The catalog boundary now plans immutable descriptors and activates them with a typed compare-and-swap request whose conflict is an explicit application outcome. Fake-port tests cover stale activation after persistence. Validation: full formatting, lint, all-target/all-feature tests, and rustdoc passed.

JayKobe6k commented

2026-09-04 00:48:08 +00:00

Review comment #920: Fixed in e190aef. Added concrete application-owned create/update/search/lineage services that orchestrate typed ports, plus fake-port sequencing and failure tests. Validation: nix develop --command cargo fmt --all -- --check, cargo lint, cargo test --all-targets --all-features, and cargo doc --no-deps --all-features.

Review comment #920: Fixed in e190aef. Added concrete application-owned create/update/search/lineage services that orchestrate typed ports, plus fake-port sequencing and failure tests. Validation: `nix develop --command cargo fmt --all -- --check`, `cargo lint`, `cargo test --all-targets --all-features`, and `cargo doc --no-deps --all-features`.

JayKobe6k merged commit 9c2027b0db into main

2026-09-04 00:49:21 +00:00

JayKobe6k referenced this pull request from a commit

2026-09-04 00:49:23 +00:00

Merge pull request 'Define typed application service boundaries' (#19) from issue-2-application-services into main

Sign in to join this conversation.

No reviewers