Define durable value handles and selectors #25

JayKobe6k · 2026-09-04T13:55:37Z

JayKobe6k commented

2026-09-04 13:55:37 +00:00

Summary

define strict revision-aware ctv1 value handles from parser-independent semantic and portable source identity
add typed exact-name selector resolution with not-found, ambiguity, stale-revision, and index-mismatch outcomes
require canonical handles on value search matches and parse handles at the CLI boundary
document the identity, serialization, and repository contracts

Closes #10

Tests

nix develop --command cargo fmt --all -- --check
nix develop --command cargo lint
nix develop --command cargo test --all-targets --all-features
nix develop --command cargo doc --no-deps --all-features
nix develop --command cargo check --target x86_64-pc-windows-gnu --all-features

## Summary - define strict revision-aware `ctv1` value handles from parser-independent semantic and portable source identity - add typed exact-name selector resolution with not-found, ambiguity, stale-revision, and index-mismatch outcomes - require canonical handles on value search matches and parse handles at the CLI boundary - document the identity, serialization, and repository contracts Closes #10 ## Tests - `nix develop --command cargo fmt --all -- --check` - `nix develop --command cargo lint` - `nix develop --command cargo test --all-targets --all-features` - `nix develop --command cargo doc --no-deps --all-features` - `nix develop --command cargo check --target x86_64-pc-windows-gnu --all-features`

JayKobe6k added 1 commit

2026-09-04 13:55:37 +00:00

Define durable value handles

Validate / Formatting, linting, and tests (push) Successful in 2m6s

Details

Validate / Formatting, linting, and tests (pull_request) Successful in 2m7s

Details

20d3d946b0

JayKobe6k referenced this pull request

2026-09-04 16:37:48 +00:00

Define shared search filtering, grouping, and ordering #27

JayKobe6k reviewed

2026-09-04 18:37:14 +00:00

JayKobe6k left a comment

Found one actionable defect in durable occurrence identity.

src/application/value.rs

					
				@ -0,0 +1279,4 @@

				        match site {

				            ValueOccurrenceSite::Source(anchor) => {

				                self.bytes(&[0]);

				                self.anchor(anchor);

[P1] Source-backed occurrences need a discriminator beyond their anchor. The existing TWICE(seed) fixture produces two distinct operand uses, but Clang reports both with spelling offset 298 and expansion offset 292. Since they also share translation unit, scope, declaration, and Operand semantic, this hashes identical input and assigns both uses one handle, conflating lineage nodes and edges. Please include a deterministic structural ordinal or path alongside the anchor and cover this macro case.

[P1] Source-backed occurrences need a discriminator beyond their anchor. The existing `TWICE(seed)` fixture produces two distinct operand uses, but Clang reports both with spelling offset 298 and expansion offset 292. Since they also share translation unit, scope, declaration, and `Operand` semantic, this hashes identical input and assigns both uses one handle, conflating lineage nodes and edges. Please include a deterministic structural ordinal or path alongside the anchor and cover this macro case.

JayKobe6k added 2 commits

2026-09-04 19:26:09 +00:00

Disambiguate durable value occurrences 0c4065a35e

Include compilation context in value identity

Validate / Formatting, linting, and tests (push) Failing after 1m59s

Details

Validate / Formatting, linting, and tests (pull_request) Successful in 2m14s

Details

cdbe3245bf

JayKobe6k commented

2026-09-04 19:26:17 +00:00

Review comment #1073: Fixed in 0c4065a (with compilation-context identity completed in cdbe324). Source-backed identities now hash a deterministic structural ordinal in addition to the full spelling/expansion anchor, and the repeated TWICE(seed) references are covered as distinct occurrences. Tests: nix develop --command cargo test --lib application::value::tests::repeated_macro_argument_uses_do_not_share_occurrence_identity -- --exact; nix develop --command cargo test --all-targets --all-features; nix develop --command cargo lint; Windows all-target check.

Review comment #1073: Fixed in 0c4065a (with compilation-context identity completed in cdbe324). Source-backed identities now hash a deterministic structural ordinal in addition to the full spelling/expansion anchor, and the repeated `TWICE(seed)` references are covered as distinct occurrences. Tests: `nix develop --command cargo test --lib application::value::tests::repeated_macro_argument_uses_do_not_share_occurrence_identity -- --exact`; `nix develop --command cargo test --all-targets --all-features`; `nix develop --command cargo lint`; Windows all-target check.

JayKobe6k merged commit 86492614bc into main

2026-09-04 21:30:14 +00:00

JayKobe6k referenced this pull request from a commit

2026-09-04 21:30:15 +00:00

Merge pull request 'Define durable value handles and selectors' (#25) from issue-10-durable-value-handles into main

Sign in to join this conversation.

No reviewers