Add end-to-end local CLI workflow coverage #35

JayKobe6k · 2026-09-06T19:21:31Z

JayKobe6k commented

2026-09-06 19:21:31 +00:00

Summary

index an isolated multi-translation-unit C project through the production CLI
verify name, project-directory, and explicit database selectors resolve the same index
exercise text and JSON searches for values, functions, structs, and enums
feed a returned value handle into bounded bidirectional lineage traversal

Tests

nix develop --command cargo fmt --all -- --check
nix develop --command cargo lint
nix develop --command cargo test --all-targets --all-features
nix develop --command cargo doc --no-deps --all-features

Begins #18.

## Summary - index an isolated multi-translation-unit C project through the production CLI - verify name, project-directory, and explicit database selectors resolve the same index - exercise text and JSON searches for values, functions, structs, and enums - feed a returned value handle into bounded bidirectional lineage traversal ## Tests - `nix develop --command cargo fmt --all -- --check` - `nix develop --command cargo lint` - `nix develop --command cargo test --all-targets --all-features` - `nix develop --command cargo doc --no-deps --all-features` Begins #18.

JayKobe6k added 1 commit

2026-09-06 19:21:31 +00:00

Add local CLI workflow coverage

Validate / Formatting, linting, and tests (pull_request) Successful in 10m22s

Details

8f54a36b79

JayKobe6k reviewed

2026-09-06 19:24:41 +00:00

JayKobe6k left a comment

Found one actionable issue.

tests/cli_workflow.rs Outdated

					
				@ -0,0 +215,4 @@

				    assert!(

				        lineage["result"]["edges"]

				            .as_array()

				            .is_some_and(|edges| !edges.is_empty())

[P2] This assertion accepts edges from either direction, so the test still passes if this bidirectional query loses all downstream traversal: second already has upstream producers that satisfy both nonempty checks, while merely echoing the downstream bound does not prove that third was reached. Please assert that the result contains nodes with both upstream and downstream depth (or equivalent producer and consumer edges) so the advertised end-to-end bidirectional path is protected.

[P2] This assertion accepts edges from either direction, so the test still passes if this bidirectional query loses all downstream traversal: `second` already has upstream producers that satisfy both nonempty checks, while merely echoing the downstream bound does not prove that `third` was reached. Please assert that the result contains nodes with both upstream and downstream depth (or equivalent producer and consumer edges) so the advertised end-to-end bidirectional path is protected.

JayKobe6k added 1 commit

2026-09-06 19:39:58 +00:00

Verify bidirectional CLI lineage

Validate / Formatting, linting, and tests (pull_request) Successful in 10m37s

Details

6da4ec4e05

JayKobe6k commented

2026-09-06 19:40:13 +00:00

Review comment #1357: Fixed in 6da4ec4. Replaced the generic nonempty result checks with assertions requiring nonzero upstream_depth and downstream_depth nodes, so the production CLI workflow now proves traversal in both directions. Tests: nix develop --command cargo test --test cli_workflow; nix develop --command cargo fmt --all -- --check; nix develop --command cargo lint; nix develop --command cargo test --all-targets --all-features; nix develop --command cargo doc --no-deps --all-features.

Review comment #1357: Fixed in 6da4ec4. Replaced the generic nonempty result checks with assertions requiring nonzero `upstream_depth` and `downstream_depth` nodes, so the production CLI workflow now proves traversal in both directions. Tests: `nix develop --command cargo test --test cli_workflow`; `nix develop --command cargo fmt --all -- --check`; `nix develop --command cargo lint`; `nix develop --command cargo test --all-targets --all-features`; `nix develop --command cargo doc --no-deps --all-features`.

JayKobe6k merged commit d0dc3c7997 into main

2026-09-06 21:14:01 +00:00

JayKobe6k referenced this pull request from a commit

2026-09-06 21:14:03 +00:00

Merge pull request 'Add end-to-end local CLI workflow coverage' (#35) from issue-18-cli-workflows into main

Sign in to join this conversation.

No reviewers