LiveMindIO/libmelee
Watch
1
0
Fork
You've already forked libmelee
 0
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity Actions

feat: add Samus extender montage #22

Open
JayKobe6k wants to merge 1 commit from feat/samus-extender-montage into master
pull from: feat/samus-extender-montage
merge into: LiveMindIO:master
Conversation 0 Commits 1 Files changed 6 +624
JayKobe6k commented 2026-09-01 12:51:12 +00:00
Owner
Copy link

Summary

  • add a frame-exact Samus extender activation and grounded grapple montage
  • support optional digital-L homing and a single caller-timed latch input
  • expose per-stock activation state and reject invalid, duplicate, or terminal requests
  • export and document the montage, including the standard Slippi tip-position limitation

Grapple-tip telemetry

Standard Slippi item updates expose Item.pos from item offsets 0x4C and 0x50. That position can identify the SAMUS_GRAPPLE_BEAM article, but it is not the simulated outer chain-tip position. Melee stores and advances the grapple as separate linked ItemLink objects; homing, gravity, walls, and chain bending update those link positions without copying the tip back into Item.pos. As a result, GameState.projectiles is insufficient for reliable contact-timed latch input.

Exact tip telemetry can be added through a custom Gecko payload or direct Dolphin memory reads using this NTSC 1.02 pointer path:

fighter + 0x223C  -> Item_GObj*
Item_GObj + 0x2C -> Item*
Item + 0xDD4     -> outer-tip ItemLink*
ItemLink + 0x0C  -> tip X float
ItemLink + 0x10  -> tip Y float
ItemLink + 0x14  -> tip Z float
Item + 0xDEA     -> extender latch-state byte

For a grounded extender, latch state 1 means its A input remains available; it advances to 2 after the input is consumed. Until this telemetry is available, callers own latch timing and should invoke grab() heuristically or manually.

Sources:

  • Project Slippi Recording/SendItemInfo.s, which emits item position from Item + 0x4C/0x50
  • doldecomp itsamusgrapple.c, which stores the outer chain link in samusgrapple.x0
  • doldecomp itlinkhookshot.c, which updates individual ItemLink transforms

Tests

  • python test.py (333 tests)
  • uvx ruff check melee/bot/techskill/extender.py melee/bot/techskill/__init__.py melee/bot/__init__.py
  • uvx ruff check test.py --ignore SIM117,B905
  • git diff --check
## Summary - add a frame-exact Samus extender activation and grounded grapple montage - support optional digital-L homing and a single caller-timed latch input - expose per-stock activation state and reject invalid, duplicate, or terminal requests - export and document the montage, including the standard Slippi tip-position limitation ## Grapple-tip telemetry Standard Slippi item updates expose `Item.pos` from item offsets `0x4C` and `0x50`. That position can identify the `SAMUS_GRAPPLE_BEAM` article, but it is not the simulated outer chain-tip position. Melee stores and advances the grapple as separate linked `ItemLink` objects; homing, gravity, walls, and chain bending update those link positions without copying the tip back into `Item.pos`. As a result, `GameState.projectiles` is insufficient for reliable contact-timed latch input. Exact tip telemetry can be added through a custom Gecko payload or direct Dolphin memory reads using this NTSC 1.02 pointer path: ```text fighter + 0x223C -> Item_GObj* Item_GObj + 0x2C -> Item* Item + 0xDD4 -> outer-tip ItemLink* ItemLink + 0x0C -> tip X float ItemLink + 0x10 -> tip Y float ItemLink + 0x14 -> tip Z float Item + 0xDEA -> extender latch-state byte ``` For a grounded extender, latch state `1` means its A input remains available; it advances to `2` after the input is consumed. Until this telemetry is available, callers own latch timing and should invoke `grab()` heuristically or manually. Sources: - Project Slippi `Recording/SendItemInfo.s`, which emits item position from `Item + 0x4C/0x50` - doldecomp `itsamusgrapple.c`, which stores the outer chain link in `samusgrapple.x0` - doldecomp `itlinkhookshot.c`, which updates individual `ItemLink` transforms ## Tests - `python test.py` (333 tests) - `uvx ruff check melee/bot/techskill/extender.py melee/bot/techskill/__init__.py melee/bot/__init__.py` - `uvx ruff check test.py --ignore SIM117,B905` - `git diff --check`
feat: add Samus extender montage
All checks were successful
Linux tests / Python 3.12 (push) Successful in 35s
Details
Linux tests / Python 3.13 (push) Successful in 35s
Details
Linux tests / Python 3.11 (push) Successful in 36s
Details
Linux tests / Python 3.11 (pull_request) Successful in 34s
Details
Linux tests / Python 3.13 (pull_request) Successful in 33s
Details
Linux tests / Python 3.12 (pull_request) Successful in 33s
Details
bbf0bb5fbe
All checks were successful
Linux tests / Python 3.12 (push) Successful in 35s
Details
Linux tests / Python 3.13 (push) Successful in 35s
Details
Linux tests / Python 3.11 (push) Successful in 36s
Details
Linux tests / Python 3.11 (pull_request) Successful in 34s
Details
Linux tests / Python 3.13 (pull_request) Successful in 33s
Details
Linux tests / Python 3.12 (pull_request) Successful in 33s
Details
This pull request has changes conflicting with the target branch.
  • AGENTS.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/samus-extender-montage:feat/samus-extender-montage
git switch feat/samus-extender-montage

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff feat/samus-extender-montage
git switch feat/samus-extender-montage
git rebase master
git switch master
git merge --ff-only feat/samus-extender-montage
git switch feat/samus-extender-montage
git rebase master
git switch master
git merge --no-ff feat/samus-extender-montage
git switch master
git merge --squash feat/samus-extender-montage
git switch master
git merge --ff-only feat/samus-extender-montage
git switch master
git merge feat/samus-extender-montage
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
area/contracts
Smithy, WIT, compatibility, or generated contracts

  
area/documentation
Architecture, operational, or user documentation

  
area/observability
Logs, metrics, traces, dashboards, or alerts

  
area/testing
Automated validation, benchmarks, or test infrastructure

  
good-first-slice
Small independently reviewable implementation slice

  
priority
p0
 Launch or security blocker

  
priority
p1
 Required for MVP

  
priority
p2
 Required after the core vertical slice

  
priority
p3
 Deferred optimization or enhancement

  
risk/legal
Requires legal or rights review

  
risk/security
Security or trust-boundary sensitive

  
status
blocked
 Blocked by an unresolved dependency or gate

  
type
epic
 Multi-issue deliverable

  
type
feature
 User-visible or system capability

  
type
spike
 Time-boxed research with a recorded decision

  
type
task
 Implementation or maintenance task

No labels
area/contracts
area/documentation
area/observability
area/testing
good-first-slice
priority
p0
priority
p1
priority
p2
priority
p3
risk/legal
risk/security
status
blocked
type
epic
type
feature
type
spike
type
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
LiveMindIO/libmelee!22
No description provided.